crtxcr
/
qswiki
1
0
Fork 0
Koodi Ongelmat 21 Pull-pyynnöt 1 Julkaisut Toiminta

HandlerPageView: Add misisng check whether passed revision is most recent

This commit is contained in:
Albert S. 2021-03-16 21:05:59 +01:00
vanhempi e4562809a0
commit 2aa11fc2b2
1 muutettua tiedostoa jossa 5 lisäystä ja 1 poistoa
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
handlers/handlerpageview.cpp
Näytä tiedosto

@ -91,9 +91,13 @@ Response HandlerPageView::handleRequest(PageDao &pageDao, std::string pagename,
if(revisionid > 0)
{
if(!effectivePermissions(pagename).canSeePageHistory())
{
auto current = this->database->createRevisionDao()->getCurrentForPage(pagename);
if(current && current->revision > revisionid)
{
return errorResponse("Error", "You are not allowed to view older revisions of this page");
}
}
revision = this->database->createRevisionDao()->getRevisionForPage(pagename, revisionid);
if(!revision)
{