crtxcr/qswiki
1
0
Garpu 0
Kode Masalah 21 Tarik Permintaan 1 Rilis Kegiatan

HandlerPageView: Add misisng check whether passed revision is most recent

Telusuri Sumber
This commit is contained in:
Albert S. 2021-03-16 21:05:59 +01:00
orang tua e4562809a0
melakukan 2aa11fc2b2
1 mengubah file dengan 5 tambahan dan 1 penghapusan
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
handlers/handlerpageview.cpp
Melihat File

@ -92,7 +92,11 @@ Response HandlerPageView::handleRequest(PageDao &pageDao, std::string pagename,
{
if(!effectivePermissions(pagename).canSeePageHistory())
{
return errorResponse("Error", "You are not allowed to view older revisions of this page");
auto current = this->database->createRevisionDao()->getCurrentForPage(pagename);
if(current && current->revision > revisionid)
{
return errorResponse("Error", "You are not allowed to view older revisions of this page");
}
}
revision = this->database->createRevisionDao()->getRevisionForPage(pagename, revisionid);
if(!revision)