crtxcr/qswiki
1
0
Vork 0
Code Kwesties 21 Pull-aanvragen 1 Publicaties Activiteit

HandlerPageView: Add misisng check whether passed revision is most recent

Bladeren bron
This commit is contained in:
Albert S. 2021-03-16 21:05:59 +01:00
bovenliggende e4562809a0
commit 2aa11fc2b2
1 gewijzigde bestanden met toevoegingen van 5 en 1 verwijderingen
Statistieken weergeven Download Patch-bestand Download Diff-bestand Expand all files Collapse all files

6
handlers/handlerpageview.cpp
Bestand weergeven

@ -92,7 +92,11 @@ Response HandlerPageView::handleRequest(PageDao &pageDao, std::string pagename,
{
if(!effectivePermissions(pagename).canSeePageHistory())
{
return errorResponse("Error", "You are not allowed to view older revisions of this page");
auto current = this->database->createRevisionDao()->getCurrentForPage(pagename);
if(current && current->revision > revisionid)
{
return errorResponse("Error", "You are not allowed to view older revisions of this page");
}
}
revision = this->database->createRevisionDao()->getRevisionForPage(pagename, revisionid);
if(!revision)