crtxcr
/
qswiki
1
0
複製 0
程式碼 問題管理 21 合併請求 1 版本發佈 Activity

HandlerPageView: Add misisng check whether passed revision is most recent

This commit is contained in:
Albert S. 2021-03-16 21:05:59 +01:00
父節點 e4562809a0
當前提交 2aa11fc2b2
共有 1 個文件被更改，包括 5 次插入 和 1 次删除
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
handlers/handlerpageview.cpp
查看文件

@ -92,7 +92,11 @@ Response HandlerPageView::handleRequest(PageDao &pageDao, std::string pagename,
{
if(!effectivePermissions(pagename).canSeePageHistory())
{
return errorResponse("Error", "You are not allowed to view older revisions of this page");
auto current = this->database->createRevisionDao()->getCurrentForPage(pagename);
if(current && current->revision > revisionid)
{
return errorResponse("Error", "You are not allowed to view older revisions of this page");
}
}
revision = this->database->createRevisionDao()->getRevisionForPage(pagename, revisionid);
if(!revision)