WIP: Rearrange Pushbuttons, Deletion, Add system entries to favourites, Save #15

Dúnta
crtxcr ag iarraidh 0 gealltanas a chumasc ó wip/rearrange go master
Úinéir

Missing

  • QIcon information loss (cannot get the icon path from it in all cases)
  • Missing assignment in Entryconfig update
  • Find next free slot in grid (next row/col) to implement "add to favoruites"
  • Deletion
Missing * [x] QIcon information loss (cannot get the icon path from it in all cases) * [x] Missing assignment in Entryconfig update * [x] Find next free slot in grid (next row/col) to implement "add to favoruites" * [x] Deletion
crtxcr cuireadh spleáchas nua 2020-09-13 21:29:18 +02:00
crtxcr cuireadh spleáchas nua 2020-09-13 21:29:40 +02:00
crtxcr athbhreithnithe 2020-09-27 22:38:45 +02:00
crtxcr d'fhág trácht
Údar
Úinéir

Problems

Problems
window.cpp As dáta
@ -126,0 +144,4 @@
QMessageBox::critical(this, "Failed to save item to favourites", e.what());
return;
}
userEntryButtons.append(createEntryButton(userConfig));
Údar
Úinéir

This is not a complete button since inheritance is not actually applied here, causing e. g. the icon not to show.

This is not a complete button since inheritance is not actually applied here, causing e. g. the icon not to show.
crtxcr mharcáil an comhrá seo mar réitigh
crtxcr athbhreithnithe 2020-09-27 22:44:05 +02:00
window.cpp As dáta
@ -126,0 +134,4 @@
userConfig.inherit = button.getEntryConfig().entryPath;
QFileInfo fi{button.getEntryConfig().entryPath};
QString entryName = fi.completeBaseName() + ".qsrun";
userConfig.entryPath = this->settingsProvider->userEntriesPaths()[0] + "/" + entryName;
Údar
Úinéir

Dirty

Dirty
Údar
Úinéir

Problem

  1. Add to favourites
  2. Rearrange
  3. Entry from 1 gets saved completely. Has inheritances property, but it's useless since everything will be stored.

Maybe:

Remove boolean
{ SYSTEM_ENTRY, USER_ENTRY, INHERITED_ENTRY }

INHERITED_ENTRY does not save anything beyond "inherit", "rows, "cols".

**Problem** 1. Add to favourites 2. Rearrange 3. Entry from 1 gets saved completely. Has inheritances property, but it's useless since everything will be stored. Maybe: Remove boolean { SYSTEM_ENTRY, USER_ENTRY, INHERITED_ENTRY } INHERITED_ENTRY does not save anything beyond "inherit", "rows, "cols".
crtxcr athbhreithnithe 2020-09-28 19:30:12 +02:00
@ -249,0 +291,4 @@
if(ret != 0)
{
qDebug() << strerror(errno);
throw std::runtime_error("Failed to save entry file( error during rename)");
Údar
Úinéir

Space

Space
crtxcr mharcáil an comhrá seo mar réitigh
crtxcr dhún an t-iarratas tarraingthe seo 2020-10-04 21:55:36 +02:00

Iarratas tarraingthe dúnta

Sínigh isteach chun dul isteach sa chomhrá seo.
Níl aon tuairisc ar fáil.