WIP: Rearrange Pushbuttons, Deletion, Add system entries to favourites, Save #15

crtxcr · 2020-09-13T21:15:13+02:00

crtxcr commented

2020-09-13 21:15:13 +02:00

Missing

QIcon information loss (cannot get the icon path from it in all cases)
Missing assignment in Entryconfig update
Find next free slot in grid (next row/col) to implement "add to favoruites"
Deletion

Missing * [x] QIcon information loss (cannot get the icon path from it in all cases) * [x] Missing assignment in Entryconfig update * [x] Find next free slot in grid (next row/col) to implement "add to favoruites" * [x] Deletion

crtxcr added a new dependency 2020-09-13 21:29:18 +02:00

#7 GUI: Rearrange entries in the GUI

crtxcr added a new dependency 2020-09-13 21:29:40 +02:00

#6 GUI: Allow adding existing .desktop files

crtxcr reviewed 2020-09-27 22:38:45 +02:00

crtxcr left a comment

Problems

window.cpp Outdated

													
				@ -126,0 +144,4 @@

						QMessageBox::critical(this, "Failed to save item to favourites", e.what());

						return;

					}

					userEntryButtons.append(createEntryButton(userConfig));

crtxcr commented

2020-09-27 22:37:29 +02:00

This is not a complete button since inheritance is not actually applied here, causing e. g. the icon not to show.

crtxcr marked this conversation as resolved

crtxcr reviewed 2020-09-27 22:44:05 +02:00

window.cpp Outdated

													
				@ -126,0 +134,4 @@

					userConfig.inherit = button.getEntryConfig().entryPath;

					QFileInfo fi{button.getEntryConfig().entryPath};

					QString entryName = fi.completeBaseName() + ".qsrun";

					userConfig.entryPath = this->settingsProvider->userEntriesPaths()[0] + "/" + entryName;

crtxcr commented

2020-09-27 22:44:05 +02:00

Dirty

crtxcr commented

2020-09-28 19:22:23 +02:00

Problem

Add to favourites
Rearrange
Entry from 1 gets saved completely. Has inheritances property, but it's useless since everything will be stored.

Maybe:

Remove boolean
{ SYSTEM_ENTRY, USER_ENTRY, INHERITED_ENTRY }

INHERITED_ENTRY does not save anything beyond "inherit", "rows, "cols".

**Problem** 1. Add to favourites 2. Rearrange 3. Entry from 1 gets saved completely. Has inheritances property, but it's useless since everything will be stored. Maybe: Remove boolean { SYSTEM_ENTRY, USER_ENTRY, INHERITED_ENTRY } INHERITED_ENTRY does not save anything beyond "inherit", "rows, "cols".

crtxcr reviewed 2020-09-28 19:30:12 +02:00

entryprovider.cpp Outdated

													
				@ -249,0 +291,4 @@

					if(ret != 0)

					{

						qDebug() << strerror(errno);

						throw std::runtime_error("Failed to save entry file( error during rename)");