crtxcr/looqs
1
0
Garpu 0
Kode Masalah Tarik Permintaan 1 Rilis Wiki Kegiatan

shared: Retire Common::findInPath() for builtin Qt function

Telusuri Sumber
This commit is contained in:
Albert S. 2022-07-24 18:19:38 +02:00
orang tua 43a0f08579
melakukan bf1265fe3a
2 mengubah file dengan 3 tambahan dan 22 penghapusan
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
shared/common.cpp
Melihat File

@ -36,32 +36,14 @@ bool Common::initSqliteDatabase(QString path)
return true;
}
QString Common::findInPath(QString needle)
{
QStringList results;
QString pathVar = QProcessEnvironment::systemEnvironment().value("PATH", "/usr/bin/:/bin/:");
QStringList paths = pathVar.split(":");
for(const QString &path : paths)
{
// TODO: can pass ../ but so be it for now.
QFileInfo info{path + "/" + needle};
if(info.exists())
{
return info.absoluteFilePath();
}
}
return "";
}
void Common::setPdfViewer()
{
QString value;
/* TODO: well, we should query this probably from xdg*/
QString okularPath = findInPath("okular");
QString evincePath = findInPath("evince");
QString qpdfviewPath = findInPath("qpdfview");
QString okularPath = QStandardPaths::findExecutable("okular");
QString evincePath = QStandardPaths::findExecutable("evince");
QString qpdfviewPath = QStandardPaths::findExecutable("qpdfview");
if(okularPath != "")
{

1
shared/common.h
Melihat File

@ -16,7 +16,6 @@ void setupAppInfo();
QString databasePath();
QString ipcSocketPath();
void setPdfViewer();
QString findInPath(QString needle);
bool initSqliteDatabase(QString path);
void ensureConfigured();
QStringList excludedPaths();