crtxcr
/
looqs
1
0
Garpu 0
Kode Masalah Tarik Permintaan 1 Rilis Wiki Kegiatan

gui: PreviewGeneratorPdf: Guard cache lookup with mutex 

No guarantes the read-only lookup is thread-safe so better
just lock there too
This commit is contained in:
Albert S. 2022-10-22 15:08:26 +02:00
orang tua 49a1a14009
melakukan 1b1ab2387e
1 mengubah file dengan 3 tambahan dan 1 penghapusan
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gui/previewgeneratorpdf.cpp
Melihat File

@ -7,10 +7,12 @@ static QMutex cacheMutex;
Poppler::Document *PreviewGeneratorPdf::document(QString path) Poppler::Document *PreviewGeneratorPdf::document(QString path)
{ {
QMutexLocker locker(&cacheMutex);
if(documentcache.contains(path)) if(documentcache.contains(path))
{ {
return documentcache.value(path); return documentcache.value(path);
} }
locker.unlock();
Poppler::Document *result = Poppler::Document::load(path); Poppler::Document *result = Poppler::Document::load(path);
if(result == nullptr) if(result == nullptr)
{ {
@ -19,7 +21,7 @@ Poppler::Document *PreviewGeneratorPdf::document(QString path)
} }
result->setRenderHint(Poppler::Document::TextAntialiasing); result->setRenderHint(Poppler::Document::TextAntialiasing);
QMutexLocker locker(&cacheMutex); locker.relock();
documentcache.insert(path, result); documentcache.insert(path, result);
locker.unlock(); locker.unlock();
return result; return result;