WIP/fixbpf #13

crtxcr · 2021-08-12T12:30:59+02:00

crtxcr kommentoi

2021-08-12 12:30:59 +02:00

Omistaja

TODO:

EACCES is hardcoded
Shrink BPF filter.

TODO: - EACCES is hardcoded - Shrink BPF filter.

crtxcr lisäsi 3 committia 2021-08-12 12:31:00 +02:00

bpf: Use SECCOMP_RET_KILL_PROCESS instead SECCOMP_RET_KILL 5cd45c09b7

We generally want to kill the process not the thread.

bpf: Check arch value 66c6d28dcd

The filter was missing this check for arch, allowing bypasses
by using different calling conventions of other architectures.

A trivial example is execve() of x86 from and x86_64 process.

bpf: Deny x32 system calls for now 51844ea3ab

The arch field is the same for x86_64 and x32, thus checking it
is not enough.

Simply using x32 system calls would allow a bypass. Thus,
we must check whether the system call number is in __X32_SYSCALL_BIT.

This is of course a lazy solution, we could also add the
same system call number + _X32_SYSCALL_BIT to our black/whitelists.

For now however, this however will do.

crtxcr force-pushed WIP/fixbpf from 89c5496fab to 83487c1699

2021-09-05 12:32:25 +02:00

Compare

crtxcr force-pushed WIP/fixbpf from 91a9b778eb to 8a9b1730de

2021-09-05 17:14:14 +02:00

Compare

crtxcr lisäsi 1 commitin 2021-09-05 17:24:46 +02:00

Rename qssb_append_default_syscall_policy() to better distinguish it from qssb_append_syscall_default_policy() 411e00715d

crtxcr lisäsi 1 commitin 2021-09-06 21:53:45 +02:00

enable_no_fs(): Fix corresponding test by adding missing default policy 215032f32c

crtxcr closed this pull request

2021-09-06 21:58:06 +02:00