crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cache: fix resource leak: close file handle before return

Browse Source 
Coverity-id: 13910
Signed-off-by: Christian Hesse <mail@eworm.de>
This commit is contained in:
Christian Hesse 2015-10-10 16:56:28 +02:00 committed by Jason A. Donenfeld
parent ed5dccbeaa
commit 76dc7a3371
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cache.c
View File

@ -215,19 +215,25 @@ static int fill_slot(struct cache_slot *slot)
return errno; return errno;
/* Redirect stdout to lockfile */ /* Redirect stdout to lockfile */
if (dup2(slot->lock_fd, STDOUT_FILENO) == -1) if (dup2(slot->lock_fd, STDOUT_FILENO) == -1) {
close(tmp);
return errno; return errno;
}
/* Generate cache content */ /* Generate cache content */
slot->fn(); slot->fn();
/* update stat info */ /* update stat info */
if (fstat(slot->lock_fd, &slot->cache_st)) if (fstat(slot->lock_fd, &slot->cache_st)) {
close(tmp);
return errno; return errno;
}
/* Restore stdout */ /* Restore stdout */
if (dup2(tmp, STDOUT_FILENO) == -1) if (dup2(tmp, STDOUT_FILENO) == -1) {
close(tmp);
return errno; return errno;
}
/* Close the temporary filedescriptor */ /* Close the temporary filedescriptor */
if (close(tmp)) if (close(tmp))