crtxcr/cgitsb
1
0
Forc 0
Cód Saincheisteanna Iarratais Tarraingthe Scaoileann Vicí Gníomhaíocht

cache: fix resource leak: close file handle before return

Brabhsáil Foinse 
Coverity-id: 13910
Signed-off-by: Christian Hesse <mail@eworm.de>
Tá an tiomantas seo le fáil i:
Christian Hesse 2015-10-10 16:56:28 +02:00 tiomanta ag Jason A. Donenfeld
tuismitheoir ed5dccbeaa
tiomantas 76dc7a3371
D'athraigh 1 comhad le 9 breiseanna agus 3 scriosta
Taispeáin Staitisticí Íoslódáil an comhad paiste Íoslódáil Comhad Diff Leathnaigh gach comhaid Laghdaigh gach comhaid

12
cache.c
Féach ar an gComhad

@ -215,19 +215,25 @@ static int fill_slot(struct cache_slot *slot)
return errno;
/* Redirect stdout to lockfile */
if (dup2(slot->lock_fd, STDOUT_FILENO) == -1)
if (dup2(slot->lock_fd, STDOUT_FILENO) == -1) {
close(tmp);
return errno;
}
/* Generate cache content */
slot->fn();
/* update stat info */
if (fstat(slot->lock_fd, &slot->cache_st))
if (fstat(slot->lock_fd, &slot->cache_st)) {
close(tmp);
return errno;
}
/* Restore stdout */
if (dup2(tmp, STDOUT_FILENO) == -1)
if (dup2(tmp, STDOUT_FILENO) == -1) {
close(tmp);
return errno;
}
/* Close the temporary filedescriptor */
if (close(tmp))