crtxcr/cgitsb
1
0
Vork 0
Code Kwesties Pull-aanvragen Publicaties Wiki Activiteit

cache: fix resource leak: close file handle before return

Bladeren bron 
Coverity-id: 13910
Signed-off-by: Christian Hesse <mail@eworm.de>
This commit is contained in:
Christian Hesse 2015-10-10 16:56:28 +02:00 gecommit door Jason A. Donenfeld
bovenliggende ed5dccbeaa
commit 76dc7a3371
1 gewijzigde bestanden met toevoegingen van 9 en 3 verwijderingen
Statistieken weergeven Download Patch-bestand Download Diff-bestand Expand all files Collapse all files

12
cache.c
Bestand weergeven

@ -215,19 +215,25 @@ static int fill_slot(struct cache_slot *slot)
return errno;
/* Redirect stdout to lockfile */
if (dup2(slot->lock_fd, STDOUT_FILENO) == -1)
if (dup2(slot->lock_fd, STDOUT_FILENO) == -1) {
close(tmp);
return errno;
}
/* Generate cache content */
slot->fn();
/* update stat info */
if (fstat(slot->lock_fd, &slot->cache_st))
if (fstat(slot->lock_fd, &slot->cache_st)) {
close(tmp);
return errno;
}
/* Restore stdout */
if (dup2(tmp, STDOUT_FILENO) == -1)
if (dup2(tmp, STDOUT_FILENO) == -1) {
close(tmp);
return errno;
}
/* Close the temporary filedescriptor */
if (close(tmp))