Compare commits

...

2 Commits

Author SHA1 Message Date
e8b89b77ab Release v0.5.1 2022-07-30 10:11:44 +02:00
77f5c7e39d gui: mainwindow: Revert pathsQuery to original behaviour
Since 7c5c91e we wrongly merge lone words for paths queries too.
This creates unintended behaviour.

Fix it by creating a new paths query without merged words, which
restores the original behaviour.

Also, get rid of some redundant calls to createFinalTokens()
2022-07-30 10:01:51 +02:00
3 changed files with 13 additions and 8 deletions

View File

@ -1,4 +1,9 @@
# looqs: Release notes # looqs: Release notes
## 2022-07-30 - v0.5.1
CHANGES:
- gui: Fix regression in implicit paths queries introduced in previous version
## 2022-07-29 - v0.5 ## 2022-07-29 - v0.5
This release features multiple fixes and enhancements. This release features multiple fixes and enhancements.

View File

@ -29,7 +29,7 @@ There is no need to write the long form of filters. There are also booleans avai
The screenshots in this section may occasionally be slightly outdated, but they are usually recent enough to get an overall impression of the current state of the GUI. The screenshots in this section may occasionally be slightly outdated, but they are usually recent enough to get an overall impression of the current state of the GUI.
## Current status ## Current status
Latest version: 2022-07-29, v0.5 Latest version: 2022-07-30, v0.5.1
Please see [Changelog](CHANGELOG.md) for a human readable list of changes. Please see [Changelog](CHANGELOG.md) for a human readable list of changes.

View File

@ -508,7 +508,6 @@ void MainWindow::lineEditReturnPressed()
LooqsQuery pathsQuery = tmpQuery; LooqsQuery pathsQuery = tmpQuery;
this->contentSearchQuery = tmpQuery; this->contentSearchQuery = tmpQuery;
this->contentSearchQuery.setTokens({});
bool addContentSearch = false; bool addContentSearch = false;
bool addPathSearch = false; bool addPathSearch = false;
@ -526,17 +525,15 @@ void MainWindow::lineEditReturnPressed()
return tokens; return tokens;
}; };
/* An explicit search, we just pass it on */ /* An explicit search, no lone words. We just pass it on */
if(!(tmpQuery.getTokensMask() & TokenType::WORD)) if(!(tmpQuery.getTokensMask() & TokenType::WORD))
{ {
if(tmpQuery.hasContentSearch()) if(tmpQuery.hasContentSearch())
{ {
this->contentSearchQuery.setTokens(createFinalTokens(TokenType::FILTER_CONTENT_CONTAINS));
addContentSearch = true; addContentSearch = true;
} }
else else
{ {
this->contentSearchQuery.setTokens(createFinalTokens(TokenType::FILTER_PATH_CONTAINS));
addPathSearch = true; addPathSearch = true;
} }
} }
@ -551,8 +548,7 @@ void MainWindow::lineEditReturnPressed()
/* A content search and lone words, e. g. c:("to be or not") ebooks */ /* A content search and lone words, e. g. c:("to be or not") ebooks */
else if(tmpQuery.hasContentSearch() && (tmpQuery.getTokensMask() & TokenType::WORD)) else if(tmpQuery.hasContentSearch() && (tmpQuery.getTokensMask() & TokenType::WORD))
{ {
this->contentSearchQuery = tmpQuery; this->contentSearchQuery = LooqsQuery::build(q, TokenType::FILTER_PATH_CONTAINS, false);
this->contentSearchQuery.setTokens(createFinalTokens(TokenType::FILTER_PATH_CONTAINS));
addContentSearch = true; addContentSearch = true;
addPathSearch = false; addPathSearch = false;
} }
@ -560,7 +556,7 @@ void MainWindow::lineEditReturnPressed()
else if(!tmpQuery.hasPathSearch() && !tmpQuery.hasContentSearch()) else if(!tmpQuery.hasPathSearch() && !tmpQuery.hasContentSearch())
{ {
this->contentSearchQuery.setTokens(createFinalTokens(TokenType::FILTER_CONTENT_CONTAINS)); this->contentSearchQuery.setTokens(createFinalTokens(TokenType::FILTER_CONTENT_CONTAINS));
pathsQuery.setTokens(createFinalTokens(TokenType::FILTER_PATH_CONTAINS)); pathsQuery = LooqsQuery::build(q, TokenType::FILTER_PATH_CONTAINS, false);
addContentSearch = true; addContentSearch = true;
addPathSearch = true; addPathSearch = true;
} }
@ -580,6 +576,10 @@ void MainWindow::lineEditReturnPressed()
} }
results.append(searcher.search(this->contentSearchQuery)); results.append(searcher.search(this->contentSearchQuery));
} }
else
{
this->contentSearchQuery.setTokens({});
}
return results; return results;
}); });
searchWatcher.setFuture(searchFuture); searchWatcher.setFuture(searchFuture);