crtxcr/looqs
1
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

mainwindow: pdfPreviewReceived(): Don't capture whole preview object in lambda

Browse Source
This commit is contained in:
Albert S. 2021-03-05 21:24:49 +01:00
parent dd053f87f9
commit d6df8d583b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gui/mainwindow.cpp
View File

@ -129,10 +129,12 @@ void MainWindow::pdfPreviewReceived(PdfPreview preview)
if(preview.hasPreviewImage()) if(preview.hasPreviewImage())
{ {
ClickLabel *label = new ClickLabel(); ClickLabel *label = new ClickLabel();
QString docPath = preview.documentPath;
auto previewPage = preview.page;
label->setPixmap(QPixmap::fromImage(preview.previewImage)); label->setPixmap(QPixmap::fromImage(preview.previewImage));
label->setToolTip(preview.documentPath); label->setToolTip(preview.documentPath);
ui->scrollAreaWidgetContents->layout()->addWidget(label); ui->scrollAreaWidgetContents->layout()->addWidget(label);
connect(label, &ClickLabel::leftClick, [=]() { connect(label, &ClickLabel::leftClick, [docPath, previewPage]() {
QSettings settings; QSettings settings;
QString command = settings.value("pdfviewer").toString(); QString command = settings.value("pdfviewer").toString();
if(command != "" && command.contains("%p") && command.contains("%f")) if(command != "" && command.contains("%p") && command.contains("%f"))
@ -142,15 +144,15 @@ void MainWindow::pdfPreviewReceived(PdfPreview preview)
{ {
QString cmd = splitted[0]; QString cmd = splitted[0];
QStringList args = splitted.mid(1); QStringList args = splitted.mid(1);
args.replaceInStrings("%f", preview.documentPath); args.replaceInStrings("%f", docPath);
args.replaceInStrings("%p", QString::number(preview.page)); args.replaceInStrings("%p", QString::number(previewPage));
QProcess::startDetached(cmd, args); QProcess::startDetached(cmd, args);
} }
} }
else else
{ {
QDesktopServices::openUrl(QUrl::fromLocalFile(preview.documentPath)); QDesktopServices::openUrl(QUrl::fromLocalFile(docPath));
} }
}); });
} }