tree: Resolve clang-tidy, clazy, compiler warnings

cli/commandadd.cpp

@@ -23,7 +23,7 @@ void CommandAdd::indexerFinished()
 	if(failedPathsCount > 0)
 	{
 		Logger::info() << "Failed paths: " << Qt::endl;
-		for(QString paths : result.failedPaths())
+		for(const QString &paths : result.failedPaths())
 		{
 			Logger::info() << paths << Qt::endl;
 		}
@@ -95,8 +95,8 @@ int CommandAdd::handle(QStringList arguments)
 	connect(indexer, &Indexer::pathsCountChanged, this,
 			[](int pathsCount) { Logger::info() << "Found paths: " << pathsCount << Qt::endl; });
 	connect(indexer, &Indexer::indexProgress, this,
-			[](int pathsCount, unsigned int added, unsigned int skipped, unsigned int failed, unsigned int totalCount)
-			{ Logger::info() << "Processed files: " << pathsCount << Qt::endl; });
+			[](int pathsCount, unsigned int /*added*/, unsigned int /*skipped*/, unsigned int /*failed*/,
+			   unsigned int /*totalCount*/) { Logger::info() << "Processed files: " << pathsCount << Qt::endl; });
 	connect(indexer, &Indexer::finished, this, &CommandAdd::indexerFinished);
 
 	this->autoFinish = false;

cli/commandlist.cpp

@@ -1,6 +1,5 @@
 #include <QCommandLineParser>
 #include "commandlist.h"
-#include "databasefactory.h"
 #include "logger.h"
 
 int CommandList::handle(QStringList arguments)

cli/commandupdate.cpp

@@ -38,7 +38,6 @@ int CommandUpdate::handle(QStringList arguments)
 		QThreadPool::globalInstance()->setMaxThreadCount(threadsCount.toInt());
 	}
 
-	bool hasErrors = false;
 	IndexSyncer *syncer = new IndexSyncer(*this->dbService);
 
 	FileSaverOptions fileOptions;
@@ -64,7 +63,7 @@ int CommandUpdate::handle(QStringList arguments)
 		/* TODO: updated not printed, handled be verbose in FileSaver, but this can be improved */
 	}
 	connect(syncer, &IndexSyncer::finished, this,
-			[&](unsigned int totalUpdated, unsigned int totalRemoved, unsigned int totalErrors)
+			[this, dryRun, keepGoing](unsigned int totalUpdated, unsigned int totalRemoved, unsigned int totalErrors)
 			{
 				Logger::info() << "Syncing finished" << Qt::endl;
 
@@ -76,7 +75,7 @@ int CommandUpdate::handle(QStringList arguments)
 				}
 
 				int retval = 0;
-				if(hasErrors && !keepGoing)
+				if(this->hasErrors && !keepGoing)
 				{
 					retval = 1;
 				}
@@ -86,7 +85,7 @@ int CommandUpdate::handle(QStringList arguments)
 			[&](QString error)
 			{
 				Logger::error() << error << Qt::endl;
-				hasErrors = true;
+				this->hasErrors = true;
 			});
 
 	this->autoFinish = false;

cli/commandupdate.h

@@ -4,6 +4,9 @@
 #include "filesaver.h"
 class CommandUpdate : public Command
 {
+  protected:
+	bool hasErrors = false;
+
   public:
 	using Command::Command;
 	int handle(QStringList arguments) override;