crtxcr/cgitsb
1
0
Fork 0
Koodi Ongelmat Pull-pyynnöt Julkaisut Wiki Toiminta

Brown paper bag: don't use grep -v

Selaa lähdekoodia 
For some inexplicable reason I'd gotten the semantics of `grep -v` totally
backwards, thinking it somehow would make the exitcode from grep indicate
the non-match of the specified pattern.

This fixes the broken tests and gives me a valuable lession about shell
programming at the same time.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
Lars Hjemli 2008-02-24 15:35:52 +01:00
vanhempi 19134112bf
commit e5ca46bf4b
2 muutettua tiedostoa jossa 5 lisäystä ja 5 poistoa
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/t0101-index.sh
Näytä tiedosto

@ -9,7 +9,7 @@ run_test 'find foo repo' 'grep -e "foo" trash/tmp'
run_test 'find foo description' 'grep -e "\[no description\]" trash/tmp'
run_test 'find bar repo' 'grep -e "bar" trash/tmp'
run_test 'find bar description' 'grep -e "the bar repo" trash/tmp'
run_test 'no tree-link' 'grep -ve "foo/tree" trash/tmp'
run_test 'no log-link' 'grep -ve "foo/log" trash/tmp'
run_test 'no tree-link' '! grep -e "foo/tree" trash/tmp'
run_test 'no log-link' '! grep -e "foo/log" trash/tmp'
tests_done

6
tests/t0102-summary.sh
Näytä tiedosto

@ -8,13 +8,13 @@ run_test 'generate foo summary' 'cgit_url "foo" >trash/tmp'
run_test 'find commit 1' 'grep -e "commit 1" trash/tmp'
run_test 'find commit 5' 'grep -e "commit 5" trash/tmp'
run_test 'find branch master' 'grep -e "master" trash/tmp'
run_test 'no tags' 'grep -ve "tags" trash/tmp'
run_test 'no tags' '! grep -e "tags" trash/tmp'
run_test 'generate bar summary' 'cgit_url "bar" >trash/tmp'
run_test 'no commit 45' 'grep -ve "commit 45" trash/tmp'
run_test 'no commit 45' '! grep -e "commit 45" trash/tmp'
run_test 'find commit 46' 'grep -e "commit 46" trash/tmp'
run_test 'find commit 50' 'grep -e "commit 50" trash/tmp'
run_test 'find branch master' 'grep -e "master" trash/tmp'
run_test 'no tags' 'grep -ve "tags" trash/tmp'
run_test 'no tags' '! grep -e "tags" trash/tmp'
tests_done