shared.c: Only setenv() if value is non-null

Some setenv() implementations (e.g. the one in OpenBSD's stdlib)
segfault if we pass a NULL value. Only set environment variables if the
corresponding settings are defined to avoid this.

Note that this is a minor behaviour change as environment variables were
supposed to be set to an empty string if a setting was undefined. Given
that this feature isn't part of any official release yet, there's no
need to worry about backwards compatibility, really. Change the
documentation accordingly.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
此提交包含在:
Lukas Fleischer
2011-09-14 11:52:43 +02:00
提交者 Lars Hjemli
父節點 8185169e5e
當前提交 d96d2c98eb
共有 2 個檔案被更改,包括 2 行新增2 行删除

查看文件

@ -500,7 +500,7 @@ Also, all filters are handed the following environment variables:
If a setting is not defined for a repository and the corresponding global If a setting is not defined for a repository and the corresponding global
setting is also not defined (if applicable), then the corresponding setting is also not defined (if applicable), then the corresponding
environment variable will be an empty string. environment variable will be unset.
MACRO EXPANSION MACRO EXPANSION

查看文件

@ -392,7 +392,7 @@ void cgit_prepare_repo_env(struct cgit_repo * repo)
p = env_vars; p = env_vars;
q = p + env_var_count; q = p + env_var_count;
for (; p < q; p++) for (; p < q; p++)
if (setenv(p->name, p->value, 1)) if (p->value && setenv(p->name, p->value, 1))
fprintf(stderr, warn, p->name, p->value); fprintf(stderr, warn, p->name, p->value);
} }