shared.c: Only setenv() if value is non-null

Some setenv() implementations (e.g. the one in OpenBSD's stdlib)
segfault if we pass a NULL value. Only set environment variables if the
corresponding settings are defined to avoid this.

Note that this is a minor behaviour change as environment variables were
supposed to be set to an empty string if a setting was undefined. Given
that this feature isn't part of any official release yet, there's no
need to worry about backwards compatibility, really. Change the
documentation accordingly.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2011-09-14 11:52:43 +02:00 committed by Lars Hjemli
부모 8185169e5e
커밋 d96d2c98eb
2개의 변경된 파일2개의 추가작업 그리고 2개의 파일을 삭제

파일 보기

@ -500,7 +500,7 @@ Also, all filters are handed the following environment variables:
If a setting is not defined for a repository and the corresponding global
setting is also not defined (if applicable), then the corresponding
environment variable will be an empty string.
environment variable will be unset.
MACRO EXPANSION

파일 보기

@ -392,7 +392,7 @@ void cgit_prepare_repo_env(struct cgit_repo * repo)
p = env_vars;
q = p + env_var_count;
for (; p < q; p++)
if (setenv(p->name, p->value, 1))
if (p->value && setenv(p->name, p->value, 1))
fprintf(stderr, warn, p->name, p->value);
}