Return 404 on command not found
We were returning 200 before. Even 404 is questionable in all cases, but 200 was totally wrong. Also match the case of all of the "Not found" status messsages. Signed-off-by: Dan McGee <dpmcgee@gmail.com> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Este commit está contenido en:
padre
42231328d3
commit
aae067197f
4
cgit.c
4
cgit.c
@ -429,7 +429,7 @@ static int prepare_repo_cmd(struct cgit_context *ctx)
|
|||||||
tmp = xstrdup(ctx->qry.head);
|
tmp = xstrdup(ctx->qry.head);
|
||||||
ctx->qry.head = ctx->repo->defbranch;
|
ctx->qry.head = ctx->repo->defbranch;
|
||||||
ctx->page.status = 404;
|
ctx->page.status = 404;
|
||||||
ctx->page.statusmsg = "not found";
|
ctx->page.statusmsg = "Not found";
|
||||||
cgit_print_http_headers(ctx);
|
cgit_print_http_headers(ctx);
|
||||||
cgit_print_docstart(ctx);
|
cgit_print_docstart(ctx);
|
||||||
cgit_print_pageheader(ctx);
|
cgit_print_pageheader(ctx);
|
||||||
@ -448,6 +448,8 @@ static void process_request(void *cbdata)
|
|||||||
cmd = cgit_get_cmd(ctx);
|
cmd = cgit_get_cmd(ctx);
|
||||||
if (!cmd) {
|
if (!cmd) {
|
||||||
ctx->page.title = "cgit error";
|
ctx->page.title = "cgit error";
|
||||||
|
ctx->page.status = 404;
|
||||||
|
ctx->page.statusmsg = "Not found";
|
||||||
cgit_print_http_headers(ctx);
|
cgit_print_http_headers(ctx);
|
||||||
cgit_print_docstart(ctx);
|
cgit_print_docstart(ctx);
|
||||||
cgit_print_pageheader(ctx);
|
cgit_print_pageheader(ctx);
|
||||||
|
Cargando…
Referencia en una nueva incidencia
Block a user