From aae067197f3fff253800359649d1f10014b23ecd Mon Sep 17 00:00:00 2001 From: Dan McGee Date: Wed, 12 Jan 2011 12:06:08 -0600 Subject: [PATCH] Return 404 on command not found We were returning 200 before. Even 404 is questionable in all cases, but 200 was totally wrong. Also match the case of all of the "Not found" status messsages. Signed-off-by: Dan McGee Signed-off-by: Lars Hjemli --- cgit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cgit.c b/cgit.c index 65fad7a..e0c2d9f 100644 --- a/cgit.c +++ b/cgit.c @@ -429,7 +429,7 @@ static int prepare_repo_cmd(struct cgit_context *ctx) tmp = xstrdup(ctx->qry.head); ctx->qry.head = ctx->repo->defbranch; ctx->page.status = 404; - ctx->page.statusmsg = "not found"; + ctx->page.statusmsg = "Not found"; cgit_print_http_headers(ctx); cgit_print_docstart(ctx); cgit_print_pageheader(ctx); @@ -448,6 +448,8 @@ static void process_request(void *cbdata) cmd = cgit_get_cmd(ctx); if (!cmd) { ctx->page.title = "cgit error"; + ctx->page.status = 404; + ctx->page.statusmsg = "Not found"; cgit_print_http_headers(ctx); cgit_print_docstart(ctx); cgit_print_pageheader(ctx);