crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull-Requests Releases Wiki Aktivität

ui-patch: make sure to send http headers

Quellcode durchsuchen 
Requesting a text/plain patch with bad commit id made cgit send text
without proper http headers. This results in "500 Internal Server Error"
with "Premature end of script headers" in server logs.
So print http headers before error message and return.

Signed-off-by: Christian Hesse <mail@eworm.de>
Reviewed-by: John Keeping <john@keeping.me.uk>
Dieser Commit ist enthalten in:
Christian Hesse 2015-08-14 00:02:50 +02:00 committet von Jason A. Donenfeld
Ursprung c543d7dbf6
Commit aa12084f98
1 geänderte Dateien mit 4 neuen und 0 gelöschten Zeilen
Statistiken anzeigen Patch-Datei herunterladen Vergleichs-Datei herunterladen Alle Dateien ausklappen Alle Dateien einklappen

4
ui-patch.c
Datei anzeigen

@ -25,21 +25,25 @@ void cgit_print_patch(const char *new_rev, const char *old_rev,
new_rev = ctx.qry.head; new_rev = ctx.qry.head;
if (get_sha1(new_rev, new_rev_sha1)) { if (get_sha1(new_rev, new_rev_sha1)) {
cgit_print_http_headers();
cgit_print_error("Bad object id: %s", new_rev); cgit_print_error("Bad object id: %s", new_rev);
return; return;
} }
commit = lookup_commit_reference(new_rev_sha1); commit = lookup_commit_reference(new_rev_sha1);
if (!commit) { if (!commit) {
cgit_print_http_headers();
cgit_print_error("Bad commit reference: %s", new_rev); cgit_print_error("Bad commit reference: %s", new_rev);
return; return;
} }
if (old_rev) { if (old_rev) {
if (get_sha1(old_rev, old_rev_sha1)) { if (get_sha1(old_rev, old_rev_sha1)) {
cgit_print_http_headers();
cgit_print_error("Bad object id: %s", old_rev); cgit_print_error("Bad object id: %s", old_rev);
return; return;
} }
if (!lookup_commit_reference(old_rev_sha1)) { if (!lookup_commit_reference(old_rev_sha1)) {
cgit_print_http_headers();
cgit_print_error("Bad commit reference: %s", old_rev); cgit_print_error("Bad commit reference: %s", old_rev);
return; return;
} }