crtxcr/cgitsb
1
0
複製 0
程式碼 問題管理 合併請求 版本發佈 Wiki Activity

ui-patch: make sure to send http headers

瀏覽代碼 
Requesting a text/plain patch with bad commit id made cgit send text
without proper http headers. This results in "500 Internal Server Error"
with "Premature end of script headers" in server logs.
So print http headers before error message and return.

Signed-off-by: Christian Hesse <mail@eworm.de>
Reviewed-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
Christian Hesse 2015-08-14 00:02:50 +02:00 committed by Jason A. Donenfeld
父節點 c543d7dbf6
當前提交 aa12084f98
共有 1 個文件被更改，包括 4 次插入 和 0 次删除
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui-patch.c
查看文件

@ -25,21 +25,25 @@ void cgit_print_patch(const char *new_rev, const char *old_rev,
new_rev = ctx.qry.head;
if (get_sha1(new_rev, new_rev_sha1)) {
cgit_print_http_headers();
cgit_print_error("Bad object id: %s", new_rev);
return;
}
commit = lookup_commit_reference(new_rev_sha1);
if (!commit) {
cgit_print_http_headers();
cgit_print_error("Bad commit reference: %s", new_rev);
return;
}
if (old_rev) {
if (get_sha1(old_rev, old_rev_sha1)) {
cgit_print_http_headers();
cgit_print_error("Bad object id: %s", old_rev);
return;
}
if (!lookup_commit_reference(old_rev_sha1)) {
cgit_print_http_headers();
cgit_print_error("Bad commit reference: %s", old_rev);
return;
}