Always check if README exists in choose_readme()

Specifying a nonexistent README file via the readme option is sometimes
useful, e.g. when using scan-path and setting a global default.
Currently, we check whether there is only one option in the readme
option and, if so, we choose that file without checking whether it
exists. As a consequence, all repositories are equipped with an about
link in the aforementioned scenario, even if there is no about file.
Remove the early check for the number of keys and always check whether
the file exists instead.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2014-07-27 20:50:59 +02:00 committed by Jason A. Donenfeld
父節點 efa2879ad7
當前提交 9dd67272ed
共有 1 個文件被更改,包括 0 次插入6 次删除

6
cgit.c
查看文件

@ -504,12 +504,6 @@ static void choose_readme(struct cgit_repo *repo)
free(ref);
continue;
}
/* If there's only one item, we skip the possibly expensive
* selection process. */
if (repo->readme.nr == 1) {
found = 1;
break;
}
if (ref) {
if (cgit_ref_path_exists(filename, ref, 1)) {
found = 1;