crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

blob: use cgit_print_error_page() to add HTTP headers

Browse Source 
This is a bugfix as well as an improvement to the HTTP status code
handling since previously we would not print HTTP headers on any of
these code paths.

Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
John Keeping 2015-08-14 12:47:06 +01:00 committed by Jason A. Donenfeld
parent 048f195eaf
commit 9a06211daa
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ui-blob.c
View File

@ -126,12 +126,14 @@ void cgit_print_blob(const char *hex, char *path, const char *head, int file_onl
if (hex) {
if (get_sha1_hex(hex, sha1)) {
cgit_print_error("Bad hex value: %s", hex);
cgit_print_error_page(400, "Bad request",
"Bad hex value: %s", hex);
return;
}
} else {
if (get_sha1(head, sha1)) {
cgit_print_error("Bad ref: %s", head);
cgit_print_error_page(404, "Not found",
"Bad ref: %s", head);
return;
}
}
@ -145,13 +147,15 @@ void cgit_print_blob(const char *hex, char *path, const char *head, int file_onl
}
if (type == OBJ_BAD) {
cgit_print_error("Bad object name: %s", hex);
cgit_print_error_page(404, "Not found",
"Bad object name: %s", hex);
return;
}
buf = read_sha1_file(sha1, &type, &size);
if (!buf) {
cgit_print_error("Error reading object %s", hex);
cgit_print_error_page(500, "Internal server error",
"Error reading object %s", hex);
return;
}