Always #include corresponding .h in .c files

While doing this, remove declarations from header files where the
corresponding definition is declared "static" in order to avoid build
errors.

Also re-order existing headers in ui-*.c so that the file-specific
header always comes immediately after "cgit.h", helping with future
consistency.

Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
John Keeping 2013-04-06 11:37:59 +01:00 committed by Jason A. Donenfeld
parent a5e4ad2d8b
commit 8f20879431
22 changed files with 20 additions and 8 deletions

1
html.c
View File

@ -6,6 +6,7 @@
* (see COPYING for full license text)
*/
#include "html.h"
#include <unistd.h>
#include <stdio.h>
#include <stdlib.h>

2
html.h
View File

@ -1,7 +1,7 @@
#ifndef HTML_H
#define HTML_H
extern int htmlfd;
#include <stddef.h>
extern void html_raw(const char *txt, size_t size);
extern void html(const char *txt);

View File

@ -8,6 +8,7 @@
*/
#include "cgit.h"
#include "scan-tree.h"
#include "configfile.h"
#include "html.h"

View File

@ -7,6 +7,7 @@
*/
#include "cgit.h"
#include "ui-atom.h"
#include "html.h"
#include "ui-shared.h"

View File

@ -8,6 +8,7 @@
*/
#include "cgit.h"
#include "ui-blob.h"
#include "html.h"
#include "ui-shared.h"

View File

@ -8,6 +8,7 @@
*/
#include "cgit.h"
#include "ui-clone.h"
#include "html.h"
#include "ui-shared.h"

View File

@ -7,6 +7,7 @@
*/
#include "cgit.h"
#include "ui-commit.h"
#include "html.h"
#include "ui-shared.h"
#include "ui-diff.h"

View File

@ -7,6 +7,7 @@
*/
#include "cgit.h"
#include "ui-diff.h"
#include "html.h"
#include "ui-shared.h"
#include "ui-ssdiff.h"

View File

@ -3,9 +3,6 @@
extern void cgit_print_diff_ctrls();
extern void cgit_print_diffstat(const unsigned char *old_sha1,
const unsigned char *new_sha1);
extern void cgit_print_diff(const char *new_hex, const char *old_hex,
const char *prefix, int show_ctrls);

View File

@ -7,6 +7,7 @@
*/
#include "cgit.h"
#include "ui-log.h"
#include "html.h"
#include "ui-shared.h"
#include "vector.h"

View File

@ -7,6 +7,7 @@
*/
#include "cgit.h"
#include "ui-patch.h"
#include "html.h"
#include "ui-shared.h"

View File

@ -8,6 +8,7 @@
#include <stdio.h>
#include "cgit.h"
#include "ui-plain.h"
#include "html.h"
#include "ui-shared.h"

View File

@ -7,6 +7,7 @@
*/
#include "cgit.h"
#include "ui-refs.h"
#include "html.h"
#include "ui-shared.h"

View File

@ -8,6 +8,7 @@
*/
#include "cgit.h"
#include "ui-repolist.h"
#include "html.h"
#include "ui-shared.h"
#include <strings.h>

View File

@ -7,6 +7,7 @@
*/
#include "cgit.h"
#include "ui-shared.h"
#include "cmd.h"
#include "html.h"

View File

@ -47,8 +47,6 @@ extern void cgit_diff_link(const char *name, const char *title,
extern void cgit_stats_link(const char *name, const char *title,
const char *class, const char *head,
const char *path);
extern void cgit_self_link(char *name, const char *title,
const char *class, struct cgit_context *ctx);
extern void cgit_object_link(struct object *obj);
extern void cgit_submodule_link(const char *class, char *path,

View File

@ -8,6 +8,7 @@
*/
#include "cgit.h"
#include "ui-snapshot.h"
#include "html.h"
#include "ui-shared.h"

View File

@ -1,8 +1,8 @@
#include "cgit.h"
#include "ui-ssdiff.h"
#include "html.h"
#include "ui-shared.h"
#include "ui-diff.h"
#include "ui-ssdiff.h"
extern int use_ssdiff;

View File

@ -1,7 +1,7 @@
#include "cgit.h"
#include "ui-stats.h"
#include "html.h"
#include "ui-shared.h"
#include "ui-stats.h"
#ifdef NO_C99_FORMAT
#define SZ_FMT "%u"

View File

@ -8,6 +8,7 @@
*/
#include "cgit.h"
#include "ui-summary.h"
#include "html.h"
#include "ui-log.h"
#include "ui-refs.h"

View File

@ -7,6 +7,7 @@
*/
#include "cgit.h"
#include "ui-tag.h"
#include "html.h"
#include "ui-shared.h"

View File

@ -8,6 +8,7 @@
#include <ctype.h>
#include "cgit.h"
#include "ui-tree.h"
#include "html.h"
#include "ui-shared.h"