crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ui-snapshot.c: Prepend "V" when guessing ref names

Browse Source 
In cgit_print_snapshot_links() we strip leading "v" and "V", while we
currently only prepend a lower case "v" when parsing a snapshot file
name. This results in broken snapshot links for tags that start with an
upper case "V". Avoid this by prepending a "V" as a fallback.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2013-04-10 13:04:03 +02:00 committed by Jason A. Donenfeld
parent 81bf4d32b3
commit 8c4c2c464b
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui-snapshot.c
View File

@ -140,8 +140,8 @@ static int make_snapshot(const struct cgit_snapshot_format *format,
* repo_basename(), we strip the basename and any following '-' and '_'
* characters ("cgit-0.7.2" -> "0.7.2") and check the resulting name once
* more. If this still isn't a valid commit object name, we check if pre-
* pending a 'v' to the remaining snapshot name ("0.7.2" -> "v0.7.2") gives
* us something valid.
* pending a 'v' or a 'V' to the remaining snapshot name ("0.7.2" ->
* "v0.7.2") gives us something valid.
*/
static const char *get_ref_from_filename(const char *url, const char *filename,
const struct cgit_snapshot_format *format)
@ -173,6 +173,10 @@ static const char *get_ref_from_filename(const char *url, const char *filename,
if (get_sha1(snapshot.buf, sha1) == 0)
goto out;
strbuf_splice(&snapshot, 0, 1, "V", 1);
if (get_sha1(snapshot.buf, sha1) == 0)
goto out;
result = 0;
strbuf_release(&snapshot);