From 9686ef30c715e09ce3521180e95899b00891a910 Mon Sep 17 00:00:00 2001
From: Albert S <mail@quitesimple.org>
Date: Sun, 13 Nov 2022 17:37:35 +0100
Subject: [PATCH] gui: PreviewResult*: Wrap result in shared pointer immediatly

---
 gui/previewresultpdf.cpp       | 4 ++--
 gui/previewresultplaintext.cpp | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/gui/previewresultpdf.cpp b/gui/previewresultpdf.cpp
index 3775cea..2b77029 100644
--- a/gui/previewresultpdf.cpp
+++ b/gui/previewresultpdf.cpp
@@ -30,7 +30,7 @@ QByteArray PreviewResultPdf::serialize() const
 
 QSharedPointer<PreviewResultPdf> PreviewResultPdf::deserialize(QByteArray &ba)
 {
-	PreviewResultPdf *result = new PreviewResultPdf();
+	QSharedPointer<PreviewResultPdf> result(new PreviewResultPdf());
 	PreviewResultType type;
 
 	QDataStream stream{&ba, QIODevice::ReadOnly};
@@ -40,5 +40,5 @@ QSharedPointer<PreviewResultPdf> PreviewResultPdf::deserialize(QByteArray &ba)
 		throw std::runtime_error("Invalid byte array: Not a pdf preview");
 	}
 	stream >> result->documentPath >> result->page >> result->previewImage;
-	return QSharedPointer<PreviewResultPdf>(result);
+	return result;
 }
diff --git a/gui/previewresultplaintext.cpp b/gui/previewresultplaintext.cpp
index ad5527f..706cefc 100644
--- a/gui/previewresultplaintext.cpp
+++ b/gui/previewresultplaintext.cpp
@@ -40,7 +40,8 @@ QByteArray PreviewResultPlainText::serialize() const
 
 QSharedPointer<PreviewResultPlainText> PreviewResultPlainText::deserialize(QByteArray &ba)
 {
-	PreviewResultPlainText *result = new PreviewResultPlainText();
+	QSharedPointer<PreviewResultPlainText> result(new PreviewResultPlainText());
+
 	PreviewResultType type;
 
 	QDataStream stream{&ba, QIODevice::ReadOnly};
@@ -50,5 +51,5 @@ QSharedPointer<PreviewResultPlainText> PreviewResultPlainText::deserialize(QByte
 		throw std::runtime_error("Invalid byte array: Not a pdf preview");
 	}
 	stream >> result->documentPath >> result->page >> result->text;
-	return QSharedPointer<PreviewResultPlainText>(result);
+	return result;
 }