Don't truncate valid cachefiles
An embarrassing thinko in cgit_check_cache() would truncate valid cachefiles in the following situation: 1) process A notices a missing/expired cachefile 2) process B gets scheduled, locks, fills and unlocks the cachefile 3) process A gets scheduled, locks the cachefile, notices that the cachefile now exist/is not expired anymore, and continues to overwrite it with an empty lockfile. Thanks to Linus for noticing (again). Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Αυτή η υποβολή περιλαμβάνεται σε:
1
cgit.h
1
cgit.h
@ -66,6 +66,7 @@ extern int cgit_parse_query(char *txt, configfn fn);
|
||||
extern void cache_prepare(struct cacheitem *item);
|
||||
extern int cache_lock(struct cacheitem *item);
|
||||
extern int cache_unlock(struct cacheitem *item);
|
||||
extern int cache_cancel_lock(struct cacheitem *item);
|
||||
extern int cache_exist(struct cacheitem *item);
|
||||
extern int cache_expired(struct cacheitem *item);
|
||||
|
||||
|
Αναφορά σε νέο ζήτημα
Block a user