Don't truncate valid cachefiles
An embarrassing thinko in cgit_check_cache() would truncate valid cachefiles in the following situation: 1) process A notices a missing/expired cachefile 2) process B gets scheduled, locks, fills and unlocks the cachefile 3) process A gets scheduled, locks the cachefile, notices that the cachefile now exist/is not expired anymore, and continues to overwrite it with an empty lockfile. Thanks to Linus for noticing (again). Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Αυτή η υποβολή περιλαμβάνεται σε:
5
cache.c
5
cache.c
@ -99,6 +99,11 @@ int cache_unlock(struct cacheitem *item)
|
||||
return (rename(fmt("%s.lock", item->name), item->name) == 0);
|
||||
}
|
||||
|
||||
int cache_cancel_lock(struct cacheitem *item)
|
||||
{
|
||||
return (unlink(fmt("%s.lock", item->name)) == 0);
|
||||
}
|
||||
|
||||
int cache_expired(struct cacheitem *item)
|
||||
{
|
||||
if (item->ttl < 0)
|
||||
|
Αναφορά σε νέο ζήτημα
Block a user