Simplify ui-commit.c
Replace the call to lookup_commit() with a call to lookup_commit_reference, since it handles reading and parsing of the commit object internally. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
parent
8960d267ed
commit
fa82b03e05
17
ui-commit.c
17
ui-commit.c
@ -13,9 +13,6 @@ void cgit_print_commit(const char *hex)
|
|||||||
struct commit *commit;
|
struct commit *commit;
|
||||||
struct commitinfo *info;
|
struct commitinfo *info;
|
||||||
struct commit_list *p;
|
struct commit_list *p;
|
||||||
unsigned long size;
|
|
||||||
char type[20];
|
|
||||||
char *buf;
|
|
||||||
|
|
||||||
unsigned char sha1[20];
|
unsigned char sha1[20];
|
||||||
|
|
||||||
@ -24,24 +21,12 @@ void cgit_print_commit(const char *hex)
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
buf = read_sha1_file(sha1, type, &size);
|
commit = lookup_commit_reference(sha1);
|
||||||
if (!buf) {
|
|
||||||
cgit_print_error(fmt("Bad object reference: %s", hex));
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
commit = lookup_commit(sha1);
|
|
||||||
if (!commit) {
|
if (!commit) {
|
||||||
cgit_print_error(fmt("Bad commit reference: %s", hex));
|
cgit_print_error(fmt("Bad commit reference: %s", hex));
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
commit->buffer = buf;
|
|
||||||
if (parse_commit_buffer(commit, buf, size)) {
|
|
||||||
cgit_print_error(fmt("Malformed commit buffer: %s", hex));
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
info = cgit_parse_commit(commit);
|
info = cgit_parse_commit(commit);
|
||||||
|
|
||||||
html("<table class='commit-info'>\n");
|
html("<table class='commit-info'>\n");
|
||||||
|
Loading…
Reference in New Issue
Block a user