crtxcr/cgitsb
1
0
複製 0
程式碼 問題管理 合併請求 版本發佈 Wiki Activity

Avoid trailing slash in virtual-root

瀏覽代碼 
When setting virtual-root from cgitrc, care is taken to avoid trailing
slashes. But when no virtual-root setting is specified, SCRIPT_FILE
from the web server is used without similar checks. This patch fixes the
inconsistency, which could lead to double-slashes in generated links.

Noticed-by: Wouter Van Hemel <wouter@duodecim.org>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
Lars Hjemli 2011-03-05 13:47:04 +01:00
父節點 fc384b16fb
當前提交 d0cb8413ff
共有 1 個文件被更改，包括 3 次插入 和 2 次删除
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cgit.c
查看文件

@ -679,10 +679,11 @@ int main(int argc, const char **argv)
http_parse_querystring(ctx.qry.raw, querystring_cb); http_parse_querystring(ctx.qry.raw, querystring_cb);
/* If virtual-root isn't specified in cgitrc, lets pretend /* If virtual-root isn't specified in cgitrc, lets pretend
* that virtual-root equals SCRIPT_NAME. * that virtual-root equals SCRIPT_NAME, minus any possibly
* trailing slashes.
*/ */
if (!ctx.cfg.virtual_root) if (!ctx.cfg.virtual_root)
ctx.cfg.virtual_root = ctx.cfg.script_name; ctx.cfg.virtual_root = trim_end(ctx.cfg.script_name, '/');
/* If no url parameter is specified on the querystring, lets /* If no url parameter is specified on the querystring, lets
* use PATH_INFO as url. This allows cgit to work with virtual * use PATH_INFO as url. This allows cgit to work with virtual