crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

parsing: clear query path before starting

Browse Source 
By specifying the "url" query parameter multiple times it is possible to
end up with ctx.qry.vpath set while ctx.repo is null, which triggers an
invalid code path from cgit_print_pageheader() while printing path
crumbs, resulting in a null dereference.

The previous patch fixed this segfault, but it makes no sense for us to
clear ctx.repo while leaving ctx.qry.path set to the previous value, so
let's just clear it here so that the last "url" parameter given takes
full effect rather than partially overriding the effect of the previous
value.

Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
John Keeping 2017-02-19 12:17:05 +00:00 committed by Jason A. Donenfeld
parent 1b4ef6783a
commit c699866699
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
parsing.c
View File

@ -21,6 +21,7 @@ void cgit_parse_url(const char *url)
struct cgit_repo *repo; struct cgit_repo *repo;
ctx.repo = NULL; ctx.repo = NULL;
ctx.qry.page = NULL;
if (!url || url[0] == '\0') if (!url || url[0] == '\0')
return; return;
@ -53,7 +54,6 @@ void cgit_parse_url(const char *url)
} }
if (cmd[1]) if (cmd[1])
ctx.qry.page = xstrdup(cmd + 1); ctx.qry.page = xstrdup(cmd + 1);
return;
} }
} }