crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

use __attribute__ to catch printf format mistakes

Browse Source 
Use "__attribute__((format (printf,N,M)))", as is done in git, do catch
mistakes in printf-style format strings.

Signed-off-by: Mark Lodato <lodatom@gmail.com>
This commit is contained in:
Mark Lodato 2010-09-04 11:09:57 -04:00
parent bf8293d319
commit a4c58d92bf
3 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cache.h
View File

@ -30,6 +30,7 @@ extern int cache_process(int size, const char *path, const char *key, int ttl,
extern int cache_ls(const char *path); extern int cache_ls(const char *path);
/* Print a message to stdout */ /* Print a message to stdout */
__attribute__((format (printf,1,2)))
extern void cache_log(const char *format, ...); extern void cache_log(const char *format, ...);
extern unsigned long hash_str(const char *str); extern unsigned long hash_str(const char *str);

1
cgit.h
View File

@ -293,6 +293,7 @@ extern void cgit_diff_tree(const unsigned char *old_sha1,
extern void cgit_diff_commit(struct commit *commit, filepair_fn fn); extern void cgit_diff_commit(struct commit *commit, filepair_fn fn);
__attribute__((format (printf,1,2)))
extern char *fmt(const char *format,...); extern char *fmt(const char *format,...);
extern struct commitinfo *cgit_parse_commit(struct commit *commit); extern struct commitinfo *cgit_parse_commit(struct commit *commit);

3
html.h
View File

@ -5,7 +5,10 @@ extern int htmlfd;
extern void html_raw(const char *txt, size_t size); extern void html_raw(const char *txt, size_t size);
extern void html(const char *txt); extern void html(const char *txt);
__attribute__((format (printf,1,2)))
extern void htmlf(const char *format,...); extern void htmlf(const char *format,...);
extern void html_status(int code, const char *msg, int more_headers); extern void html_status(int code, const char *msg, int more_headers);
extern void html_txt(const char *txt); extern void html_txt(const char *txt);
extern void html_ntxt(int len, const char *txt); extern void html_ntxt(int len, const char *txt);