crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ui-summary.c: Move urls variable into print_urls()

Browse Source 
There's no need for this variable to be global. Printing the header in
print_urls() instead of print_url() allows for moving this variable into
print_urls() without having to pass any status to print_url().

Note that this only works as long as we don't call print_urls() more
than once.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2013-03-05 16:48:27 +01:00 committed by Jason A. Donenfeld
parent ef8a97d9c6
commit 977a3ad7bf
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ui-summary.c
View File

@ -13,8 +13,6 @@
#include "ui-refs.h" #include "ui-refs.h"
#include "ui-blob.h" #include "ui-blob.h"
int urls = 0;
static void print_url(char *base, char *suffix) static void print_url(char *base, char *suffix)
{ {
int columns = 3; int columns = 3;
@ -26,10 +24,6 @@ static void print_url(char *base, char *suffix)
if (!base || !*base) if (!base || !*base)
return; return;
if (urls++ == 0) {
htmlf("<tr class='nohover'><td colspan='%d'>&nbsp;</td></tr>", columns);
htmlf("<tr><th class='left' colspan='%d'>Clone</th></tr>\n", columns);
}
if (suffix && *suffix) if (suffix && *suffix)
base = fmt("%s/%s", base, suffix); base = fmt("%s/%s", base, suffix);
htmlf("<tr><td colspan='%d'><a href='", columns); htmlf("<tr><td colspan='%d'><a href='", columns);
@ -42,15 +36,29 @@ static void print_url(char *base, char *suffix)
static void print_urls(char *txt, char *suffix) static void print_urls(char *txt, char *suffix)
{ {
char *h = txt, *t, c; char *h = txt, *t, c;
int urls = 0;
int columns = 3;
if (ctx.repo->enable_log_filecount)
columns++;
if (ctx.repo->enable_log_linecount)
columns++;
while (h && *h) { while (h && *h) {
while (h && *h == ' ') while (h && *h == ' ')
h++; h++;
if (!*h)
break;
t = h; t = h;
while (t && *t && *t != ' ') while (t && *t && *t != ' ')
t++; t++;
c = *t; c = *t;
*t = 0; *t = 0;
if (urls++ == 0) {
htmlf("<tr class='nohover'><td colspan='%d'>&nbsp;</td></tr>", columns);
htmlf("<tr><th class='left' colspan='%d'>Clone</th></tr>\n", columns);
}
print_url(h, suffix); print_url(h, suffix);
*t = c; *t = c;
h = t; h = t;