crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ui-snapshot: avoid segfault when no filename is specified

Browse Source 
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
Lars Hjemli 2009-03-15 08:57:33 +01:00
parent 112973615a
commit 6fddad7251
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
ui-snapshot.c
View File

@ -156,20 +156,31 @@ static const char *get_ref_from_filename(const char *url, const char *filename,
return NULL; return NULL;
} }
void show_error(char *msg)
{
ctx.page.mimetype = "text/html";
cgit_print_http_headers(&ctx);
cgit_print_docstart(&ctx);
cgit_print_pageheader(&ctx);
cgit_print_error(msg);
cgit_print_docend();
}
void cgit_print_snapshot(const char *head, const char *hex, void cgit_print_snapshot(const char *head, const char *hex,
const char *filename, int snapshots, int dwim) const char *filename, int snapshots, int dwim)
{ {
const struct cgit_snapshot_format* f; const struct cgit_snapshot_format* f;
char *prefix = NULL; char *prefix = NULL;
if (!filename) {
show_error("No snapshot name specified");
return;
}
f = get_format(filename); f = get_format(filename);
if (!f) { if (!f) {
ctx.page.mimetype = "text/html"; show_error(xstrdup(fmt("Unsupported snapshot format: %s",
cgit_print_http_headers(&ctx); filename)));
cgit_print_docstart(&ctx);
cgit_print_pageheader(&ctx);
cgit_print_error(fmt("Unsupported snapshot format: %s", filename));
cgit_print_docend();
return; return;
} }