crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ui-atom: properly escape delimiter in page link

Browse Source 
If the delimiter here is '&' then it needs to be escaped for inclusion
in an attribute.  Use html_attrf() to ensure that this happens (we know
that hex won't need escaping, but this makes it clearer what's
happening.

Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
John Keeping 2017-01-15 12:29:38 +00:00 committed by Jason A. Donenfeld
parent 86a6d358f7
commit 6d3c8bc37f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui-atom.c
View File

@ -63,7 +63,7 @@ static void add_entry(struct commit *commit, const char *host)
html_attr(pageurl); html_attr(pageurl);
if (ctx.cfg.virtual_root) if (ctx.cfg.virtual_root)
delim = '?'; delim = '?';
htmlf("%cid=%s", delim, hex); html_attrf("%cid=%s", delim, hex);
html("'/>\n"); html("'/>\n");
free(pageurl); free(pageurl);
} }