filter: pass extra arguments via cgit_open_filter

This avoids poking into the filter data structure at various points in
the code.  We rely on the fact that the number of arguments is fixed
based on the filter type (set in cgit_new_filter) and that the call
sites all know which filter type they're using.

Signed-off-by: John Keeping <john@keeping.me.uk>
这个提交包含在:
John Keeping
2014-01-12 17:13:50 +00:00
提交者 Jason A. Donenfeld
父节点 da218fcd9e
当前提交 3d8a6507ca
共有 5 个文件被更改,包括 38 次插入30 次删除

3
cgit.h
查看文件

@@ -59,6 +59,7 @@ typedef enum {
struct cgit_filter {
char *cmd;
char **argv;
int extra_args;
int old_stdout;
int pipe_fh[2];
int pid;
@@ -342,7 +343,7 @@ extern const char *cgit_repobasename(const char *reponame);
extern int cgit_parse_snapshots_mask(const char *str);
extern int cgit_open_filter(struct cgit_filter *filter);
extern int cgit_open_filter(struct cgit_filter *filter, ...);
extern int cgit_close_filter(struct cgit_filter *filter);
extern struct cgit_filter *cgit_new_filter(const char *cmd, filter_type filtertype);