Add regression-test for description-less repos
The segfault fixed in commit eacde43d71
was
triggered when the html-functions manipulated string literals. One callpatch
which could trigger the bug is in ui-repolist.c when repo descriptions are
passed to html_ntxt(): if a repo is lacking a description, the literal
string "[no description]" is used.
This patch changes test/setup.sh such that the first repo has no description,
and adds tests for both "[no description]" and "the bar repo" (description
of the other repo) to tests/t0101-index.sh, which should be enought to catch
regressions in these functions.
Noticed-by: Hiroki Hattori <seagull.kamome@gmail.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
@ -54,7 +54,9 @@ summary-tags=5
|
||||
|
||||
repo.url=foo
|
||||
repo.path=$PWD/trash/repos/foo/.git
|
||||
repo.desc=the foo repo
|
||||
# Do not specify a description for this repo, as it then will be assigned
|
||||
# the constant value "[no description]" (which actually used to cause a
|
||||
# segfault).
|
||||
|
||||
repo.url=bar
|
||||
repo.path=$PWD/trash/repos/bar/.git
|
||||
|
Reference in New Issue
Block a user