crtxcr/cgitsb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ui-shared: remove toggle_ssdiff arg to cgit_diff_link()

Browse Source 
This argument is never used with a value other than zero, so remove it
and simplify the code.

Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
John Keeping 2014-10-05 10:59:03 +01:00 committed by Lukas Fleischer
parent eeddb5bc09
commit 03f537f1a1
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui-commit.c
View File

@ -99,7 +99,7 @@ void cgit_print_commit(char *hex, const char *prefix)
cgit_commit_link(tmp2, NULL, NULL, ctx.qry.head, tmp, prefix); cgit_commit_link(tmp2, NULL, NULL, ctx.qry.head, tmp, prefix);
html(" ("); html(" (");
cgit_diff_link("diff", NULL, NULL, ctx.qry.head, hex, cgit_diff_link("diff", NULL, NULL, ctx.qry.head, hex,
sha1_to_hex(p->item->object.sha1), prefix, 0); sha1_to_hex(p->item->object.sha1), prefix);
html(")</td></tr>"); html(")</td></tr>");
parents++; parents++;
} }

4
ui-diff.c
View File

@ -97,7 +97,7 @@ static void print_fileinfo(struct fileinfo *info)
} }
htmlf("</td><td class='%s'>", class); htmlf("</td><td class='%s'>", class);
cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1, cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1,
ctx.qry.sha2, info->new_path, 0); ctx.qry.sha2, info->new_path);
if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) { if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) {
htmlf(" (%s from ", htmlf(" (%s from ",
info->status == DIFF_STATUS_COPIED ? "copied" : "renamed"); info->status == DIFF_STATUS_COPIED ? "copied" : "renamed");
@ -175,7 +175,7 @@ static void cgit_print_diffstat(const unsigned char *old_sha1,
html("<div class='diffstat-header'>"); html("<div class='diffstat-header'>");
cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1,
ctx.qry.sha2, NULL, 0); ctx.qry.sha2, NULL);
if (prefix) { if (prefix) {
html(" (limited to '"); html(" (limited to '");
html_txt(prefix); html_txt(prefix);

8
ui-shared.c
View File

@ -385,7 +385,7 @@ void cgit_snapshot_link(const char *name, const char *title, const char *class,
void cgit_diff_link(const char *name, const char *title, const char *class, void cgit_diff_link(const char *name, const char *title, const char *class,
const char *head, const char *new_rev, const char *old_rev, const char *head, const char *new_rev, const char *old_rev,
const char *path, int toggle_ssdiff) const char *path)
{ {
char *delim; char *delim;
@ -402,7 +402,7 @@ void cgit_diff_link(const char *name, const char *title, const char *class,
html_url_arg(old_rev); html_url_arg(old_rev);
delim = "&amp;"; delim = "&amp;";
} }
if ((ctx.qry.ssdiff && !toggle_ssdiff) || (!ctx.qry.ssdiff && toggle_ssdiff)) { if (ctx.qry.ssdiff) {
html(delim); html(delim);
html("ss=1"); html("ss=1");
delim = "&amp;"; delim = "&amp;";
@ -478,7 +478,7 @@ static void cgit_self_link(char *name, const char *title, const char *class)
else if (!strcmp(ctx.qry.page, "diff")) else if (!strcmp(ctx.qry.page, "diff"))
cgit_diff_link(name, title, class, ctx.qry.head, cgit_diff_link(name, title, class, ctx.qry.head,
ctx.qry.sha1, ctx.qry.sha2, ctx.qry.sha1, ctx.qry.sha2,
ctx.qry.path, 0); ctx.qry.path);
else if (!strcmp(ctx.qry.page, "stats")) else if (!strcmp(ctx.qry.page, "stats"))
cgit_stats_link(name, title, class, ctx.qry.head, cgit_stats_link(name, title, class, ctx.qry.head,
ctx.qry.path); ctx.qry.path);
@ -876,7 +876,7 @@ void cgit_print_pageheader(void)
cgit_commit_link("commit", NULL, hc("commit"), cgit_commit_link("commit", NULL, hc("commit"),
ctx.qry.head, ctx.qry.sha1, ctx.qry.vpath); ctx.qry.head, ctx.qry.sha1, ctx.qry.vpath);
cgit_diff_link("diff", NULL, hc("diff"), ctx.qry.head, cgit_diff_link("diff", NULL, hc("diff"), ctx.qry.head,
ctx.qry.sha1, ctx.qry.sha2, ctx.qry.vpath, 0); ctx.qry.sha1, ctx.qry.sha2, ctx.qry.vpath);
if (ctx.repo->max_stats) if (ctx.repo->max_stats)
cgit_stats_link("stats", NULL, hc("stats"), cgit_stats_link("stats", NULL, hc("stats"),
ctx.qry.head, ctx.qry.vpath); ctx.qry.head, ctx.qry.vpath);

2
ui-shared.h
View File

@ -43,7 +43,7 @@ extern void cgit_snapshot_link(const char *name, const char *title,
extern void cgit_diff_link(const char *name, const char *title, extern void cgit_diff_link(const char *name, const char *title,
const char *class, const char *head, const char *class, const char *head,
const char *new_rev, const char *old_rev, const char *new_rev, const char *old_rev,
const char *path, int toggle_ssdiff); const char *path);
extern void cgit_stats_link(const char *name, const char *title, extern void cgit_stats_link(const char *name, const char *title,
const char *class, const char *head, const char *class, const char *head,
const char *path); const char *path);